cluster_minority_SUITE: Fix race in remove_node_when_seed_node_is_leader (backport #14150)
#14160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ader`
[Why]
When node A becomes the leader, it still takes a few exchanges with
followers to allow cluster changes again.
Concurrently, the testcase blocks traffic between A and other nodes to
simulate a network partition. If this happens after A becomes the leader
but before cluster changes are permitted again, the testcase will never
succeed and will eventually abort with:
Case: cluster_minority_SUITE:remove_node_when_seed_node_is_leader
Reason: {error,
{{awaitMatch,
[{module,cluster_minority_SUITE},
{expression, "..."},
{pattern,"ok"},
{value,
{error,69,<<"Error:\ncluster_change_not_permitted">>}}]},
[How]
Before blocking traffic, we wait for cluster changes to be permitted
again on node A.
(cherry picked from commit 7166357)
# Conflicts:
# deps/rabbit/test/cluster_minority_SUITE.erl
Author
|
Cherry-pick of 7166357 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Collaborator
|
In fact, the testcase is quite different compared to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When node A becomes the leader, it still takes a few exchanges with followers to allow cluster changes again.
Concurrently, the testcase blocks traffic between A and other nodes to simulate a network partition. If this happens after A becomes the leader but before cluster changes are permitted again, the testcase will never succeed and will eventually abort with:
How
Before blocking traffic, we wait for cluster changes to be permitted again on node A.
This is an automatic backport of pull request #14150 done by Mergify.